Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when root view controller have to be defined by developer using setRootViewController #129

Open
wants to merge 87 commits into
base: master
Choose a base branch
from

Conversation

rs
Copy link

@rs rs commented Nov 22, 2010

This bug was introduced by 0e3dd3e

To reproduce, just use the library in a way it can't determine the root view controller by itself and set it using advised [[SHK currentHelper] setRootViewController:...]; then use a service which require more than one modal view (i.e.: unlogged twitter in xauth mode).

ideashower and others added 30 commits July 6, 2010 14:17
- Debug switch
- ModalPresentationStyle (for iPad apps)
- ModalTransitionStyle (for iPad apps)

New Features:
- Logout of all services +[SHK logoutOfAll]
- Logout of specific service +[SHK logoutOfService:serviceId]

Critical Fixes:
- Delicious token expiring after 1 hour
- Bit.ly could return non-bit.ly domains causing shortened url to be rejected

Minor Improvements:
- SHKActionSheet tried to act on indexes less than 0
- Cancelling OAuth login no longer prompts 'user cancelled' error message

Other bug fixes
- Fixed facebook logout
- Added additional comments for setting up twitter
- Added sanity check to catch pin based auth with twitter
- Version 0.1.6 - release going to website
You can add your own language by simply adding your lang in ShareKit.bundle.

You have to include ShareKit.bundle now in your project
…t were evaluated on clickedButtonAtIndex. This produced a black screen when no mail client was setup, mail was a favorite and the user pressed "more".
- SHKPhotoAlbum: Save images to photo album action
- Facebook accepts text sharing

Fixes:
- SHKItem now carries over full item when sharing
- Crash when saving items offline that did not contain custom variables
- Modal popups would not go away when using pagesheet modal type on iPad
- Editing sharers now affects actionsheet choices
- Race condition in SHKShareMenu

Improvements:
- Improved display of SHKTwitterForm on iPad
- Facebook uses text variable when sharing urls to repopulate status message
- SHKMail now uses up to date template, improved handling of text when it's available in SHKItem
- Updated SHKActionSheet to not override delegate, now you can assign your own delegate

Code Refactoring:
- Renamed SHLocalizedString to use proper SHK prefix
- Updated SHKLocalizedString to work like stringWithFormat
- Removed/Combined some localization strings
-SHKTwitter: Don't attempt to shorten while offline
-SHKTwitter: Crash on @"Follow %@" format string
-SHKEmail: Added 'Sent with ...'
-SHKDelicious: Titles were double encoded
-SHK: SHKStringOrBlank function

-Updated FBConnect to version 1.3.0
ideashower and others added 30 commits November 14, 2010 21:51
…r had been released (it's never retained by the library).
Share Text Message through Text button to launch
Messages on iOS4 only.
- Cleaned up Evernote Sharer
- Added error handling to Evernote Sharer
- Fixed bug where Mail would not dimiss after opening address book
- Fixed cancelation notification not sending for Twitter
- Updated obj-class import
- Fixed logic error missing attachments when body is set
- Fixed mail showing empty view when mail is not configured
- Cleaned up text message sharer
Conflicts:
	Classes/ShareKit/Core/Base Sharer Classes/SHKSharer.m
	Classes/ShareKit/Core/SHK.m
	Classes/ShareKit/Sharers/Actions/Text Message/SHKTextMessage.m
	Classes/ShareKit/UI/SHKActionSheet.m
	ShareKit.xcodeproj/project.pbxproj
…k and generate an embed player attachement
…player to the post with the ability to append some text bellow it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet